Repository navigation
tests: run strace tests on Android - #16721
Open
costajohnt wants to merge 1 commit into
Open
costajohnt wants to merge 1 commit into
costajohnt wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widen the
target_os = "linux"gate to also cover Android for the strace based tests intest_dd,test_install,test_ls,test_rm,test_shredandtest_shuf. The code paths they exercise (fadvisefordd oflag=nocache,spliceinuucore::pipes,FICLONEreflink, thegetrandomfallback) are already built for Android.Each of these tests already skips when
stracecan't be run, so this is safe whether or not the Android runner has it. I left the runner setup alone since #16675 replaces the Termux flow; oncestraceis available on the device the tests run instead of skipping.Tested:
cargo check --tests --target x86_64-linux-androidwith the touched utils, and on Linuxcargo testfor the 9 tests (with strace installed, so they actually ran),cargo clippy --tests --features feat_os_unix -- -D warningsandcargo fmt --check. Whether they pass on the emulator is up to the Android CI job.Fixes #16705