Skip to content

tests: run strace tests on Android - #16721

Open
costajohnt wants to merge 1 commit into
uutils:mainfrom
costajohnt:tests/android-strace
Open

costajohnt wants to merge 1 commit into
uutils:mainfrom
costajohnt:tests/android-strace

Conversation

@costajohnt

Copy link
Copy Markdown
Contributor

Widen the target_os = "linux" gate to also cover Android for the strace based tests in test_dd, test_install, test_ls, test_rm, test_shred and test_shuf. The code paths they exercise (fadvise for dd oflag=nocache, splice in uucore::pipes, FICLONE reflink, the getrandom fallback) are already built for Android.

Each of these tests already skips when strace can't be run, so this is safe whether or not the Android runner has it. I left the runner setup alone since #16675 replaces the Termux flow; once strace is available on the device the tests run instead of skipping.

Tested: cargo check --tests --target x86_64-linux-android with the touched utils, and on Linux cargo test for the 9 tests (with strace installed, so they actually ran), cargo clippy --tests --features feat_os_unix -- -D warnings and cargo fmt --check. Whether they pass on the emulator is up to the Android CI job.

Fixes #16705

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run strace tests on Android

1 participant